Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add com.snowplowanalytics.snowplow/application/jsonschema/1-0-0 (close #1418) #1419

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

matus-tomlein
Copy link
Contributor

Add a schema for the application context entity tracked in Web and other apps that specifies the version number of the application. This can be in the form of semver or a Git commit SHA, so the schema doesn't put any further limits on it other than the max length.

Note that we already have a application context entity that is tracked on mobile – it has the vendor com.snowplowanalytics.mobile. In addition to the version, it also has a required build property that is available in mobile app builds. We can't reuse the same as the build number is not so useful on Web apps.

@johnmicahreid
Copy link

LGTM

Copy link

@johnmicahreid johnmicahreid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matus-tomlein matus-tomlein changed the base branch from master to release/r163 November 14, 2024 09:19
@matus-tomlein matus-tomlein merged commit aae3810 into release/r163 Nov 14, 2024
1 check passed
@matus-tomlein matus-tomlein deleted the issue/1418-application_context branch November 14, 2024 09:20
@matus-tomlein matus-tomlein mentioned this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants