-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/r161 #1412
Release/r161 #1412
Conversation
@matus-tomlein @istreeter silly question here but if we are going to need to patch Why do we prefer this approach to just patching |
@jbeemster Happy to go with just patching |
In terms of risk... both approaches are equally safe in theory with roughly equal amount of risk if we get something wrong. Or possibly slightly less risk to do Josh's latest idea of patch the schema. On the other hand: Going forwards we want to take a position with customers/users where we strongly discourage (or even forbid) patching their schemas. So it's not great to have a rule for customers if we break the rule in Iglu Central. On the 3rd hand: Consider BigQuery v1 users. As soon as you merge this PR, all existing BigQuery v1 loaders will suddenly start loading the context into a That final argument makes me lean towards patching the schema instead of superseding it. |
@istreeter @matus-tomlein assuming the patch is safe lets do that rather than make a much bigger amount of work out of all of this. |
…lose #1410) Add $supersededBy relation to the 1-0-3 schema
3d08f62
to
88a7ac0
Compare
Sounds good! Have just updated the PR to only have the 1-0-2 patch. |
This release contains the schema for the
client_session
entity version 1-0-3 that supersedes the 1-0-2 version. It adds the$supersededBy
relation to the 1-0-2 version and thesupersedes
relation to the 1-0-3 version. The change in the 1-0-3 schema is that thepreviousSessionId
property is no longer required (not a breaking change since it was nullable).Changes
Needs extra attention as this is the first time that we use the supersedes relation in Iglu Central and the
client_session
schema is a popular one.