-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add schemas for screen engagement tracking on mobile #1358
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few Qs
schemas/com.snowplowanalytics.snowplow/screen_end/jsonschema/1-0-0
Outdated
Show resolved
Hide resolved
schemas/com.snowplowanalytics.snowplow/screen_time/jsonschema/1-0-0
Outdated
Show resolved
Hide resolved
schemas/com.snowplowanalytics.snowplow/view_segment/jsonschema/1-0-0
Outdated
Show resolved
Hide resolved
schemas/com.snowplowanalytics.snowplow/view_segment/jsonschema/1-0-0
Outdated
Show resolved
Hide resolved
56a42d4
to
53c6f8c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last question, do we have any other events that have no properties (that's aren't the page ping). Just wondering how this will work with the loader in terms of creating a column... @jbeemster ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do have a few events like that – the application_install
event is quite a common one for example. Checking our dev1 Snowflake atomic events, I don't see a column for it, so probably the column is not created if the event schema has no properties?
53c6f8c
to
b2a5a59
Compare
As I was implementing this in the iOS tracker, I iterated a bit on the schemas. I recorded a short video to demo how the schemas will be used in tracking, it can be found here. Overall the changes are:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few questions because I don't develop mobile apps so don't really know what this means
schemas/com.snowplowanalytics.mobile/list_item_view/jsonschema/1-0-0
Outdated
Show resolved
Hide resolved
schemas/com.snowplowanalytics.mobile/screen_summary/jsonschema/1-0-0
Outdated
Show resolved
Hide resolved
4b07581
to
4a49796
Compare
Final update: after some discussion, we also added scroll view tracking in pixels (in addition to the list view tracking). We can't provide automatic tracking for this, but users can listen for scroll changed events in their scroll views and track a |
Can mobile applications have an x offset and width greater than the screen? |
4a49796
to
dfad2d6
Compare
It'd be quite rare, but actually why not add it since we also have the horizontal scroll depth on Web too... Have updated the schemas to make it possible to track too. |
dfad2d6
to
bde249f
Compare
One more update: have also added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Cherry picked to R152 |
This PR adds 3 schemas for screen engagement tracking on mobile (
screen_time
andscreen_end
) and both on mobile and Web (view_segment
).These schema support the proposal presented in this demo.
screen_time
andview_segment
entities