Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add schemas/dev.amp.snowplow/amp_consent/jsonschema/1-0-0 #1329

Closed
wants to merge 1 commit into from
Closed

Add schemas/dev.amp.snowplow/amp_consent/jsonschema/1-0-0 #1329

wants to merge 1 commit into from

Conversation

igneel64
Copy link
Contributor

Add AMP consent schema for the amp tracker feature snowplow-incubator/amphtml#19

close #1328

@igneel64 igneel64 mentioned this pull request Aug 22, 2023
Open
@igneel64 igneel64 mentioned this pull request Aug 23, 2023
Draft
matus-tomlein
matus-tomlein approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@matus-tomlein matus-tomlein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Based on the implementation, it seems like the properties could also be required, but no problem if you think that it's safer to keep them optional.

colmsnowplow
colmsnowplow approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@colmsnowplow colmsnowplow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@igneel64 igneel64 force-pushed the issue/1328-add_amp_consent_schema branch from 2190fd0 to 57a3baf Compare September 22, 2023 14:00
@adatzer adatzer changed the base branch from master to release/r148 October 27, 2023 12:04
@adatzer
Copy link
Contributor

adatzer commented Oct 27, 2023

Rebased and merged into release/r148. Closing.

@adatzer adatzer closed this Oct 27, 2023
@matus-tomlein matus-tomlein mentioned this pull request Oct 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colmsnowplow colmsnowplow colmsnowplow approved these changes

@matus-tomlein matus-tomlein matus-tomlein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add dev.amp.snowplow/amp_consent/jsonschema/1-0-0
4 participants
@igneel64 @adatzer @matus-tomlein @colmsnowplow