Draft currency conversion configuration #790
Conversation
| @@ -11,6 +10,50 @@ | |||
| "apiKey": "{{KEY}}", | |||
| "baseCurrency": "USD", | |||
| "rateAt": "EOD_PRIOR" | |||
There was a problem hiding this comment.
@istreeter What's your opinion on exposing the caching settings in parameters here similar to what we do for the API enrichment?
There was a problem hiding this comment.
I paused for ages on this question! It makes me nervous to expose such a powerful setting in such a user-facing piece of config. Cache size is a balance between performance vs available memory, and the person configuring this enrichment might not know all of the context for tuning that.
On balance, though, it's better to make it configurable because we never know when we'll need to tune things at run time. So yeah we should put it in this config.
@miike what's your opinion on the ignoreOnError setting that is newly added to the sql enrichment config? If we added it here, it would basically mean.... if we fail to fetch a rate because of a network error, then it's OK to emit the event without the derived context.
There was a problem hiding this comment.
I like the idea of ignoreOnError as there are going to be circumstances where a failed enrichment event (e.g., on checkout) is going to be annoying to not have because a currency conversion couldn't be performed.
I think this does raise the question (for both enrichments) about how you "recover" data that hasn't generated a failed event but might be NULL in the data warehouse though. I don't know that we can (or want to?) change our philosophy around the immutability of these events.
No description provided.