Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/snowplow normalize/0.3.5 #40

Merged
merged 3 commits into from
Mar 18, 2024
Merged

Conversation

rlh1994
Copy link
Contributor

@rlh1994 rlh1994 commented Mar 13, 2024

Description

This PR adds schema grant support, adds missing arg in delete from manifest

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

https://snplow.atlassian.net/browse/PE-5867
https://www.notion.so/keep-in-the-snow/Normalize-71c3ef79bb2d4db78271a310410e272e

Checklist

  • ❗️ I have verified that these changes work on Redshift
  • πŸ’£ Is your change a breaking change?
  • πŸ“– I have updated the CHANGELOG.md

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ““ internal package docs (ymls, macros, readme, if applicable)
  • πŸ“• I have raised a Snowplow documentation PR if applicable (Link here if required)
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

Release Only Checklist

  • I have updated the version number in all relevant places
  • I have changed the release date in the CHANGELOG.md

@rlh1994 rlh1994 requested a review from a team March 13, 2024 10:10
Copy link

github-actions bot commented Mar 13, 2024

Test Coverage

Test Coverage Report - Python 3.7
FileStmtsMissCoverMissing
snowplow_model_gen_funcs.py144497%115–116, 202, 256
TOTAL144497%Β 

Python 3.7 Test Results

Tests Skipped Failures Errors Time
56 0 πŸ’€ 0 ❌ 0 πŸ”₯ 5.621s ⏱️

Copy link

github-actions bot commented Mar 13, 2024

Test Coverage

Test Coverage Report - Python 3.8
FileStmtsMissCoverMissing
snowplow_model_gen_funcs.py144497%115–116, 202, 256
TOTAL144497%Β 

Python 3.8 Test Results

Tests Skipped Failures Errors Time
56 0 πŸ’€ 0 ❌ 0 πŸ”₯ 5.902s ⏱️

Copy link

github-actions bot commented Mar 13, 2024

Test Coverage

Test Coverage Report - Python 3.9
FileStmtsMissCoverMissing
snowplow_model_gen_funcs.py144497%115–116, 202, 256
TOTAL144497%Β 

Python 3.9 Test Results

Tests Skipped Failures Errors Time
56 0 πŸ’€ 0 ❌ 0 πŸ”₯ 3.743s ⏱️

Copy link

github-actions bot commented Mar 13, 2024

Test Coverage

Test Coverage Report - Python 3.10
FileStmtsMissCoverMissing
snowplow_model_gen_funcs.py144497%115–116, 202, 256
TOTAL144497%Β 

Python 3.10 Test Results

Tests Skipped Failures Errors Time
56 0 πŸ’€ 0 ❌ 0 πŸ”₯ 5.787s ⏱️

@rlh1994 rlh1994 force-pushed the release/snowplow-normalize/0.3.5 branch from 4407761 to 7c9c2d7 Compare March 13, 2024 10:27
@rlh1994 rlh1994 force-pushed the release/snowplow-normalize/0.3.5 branch from 7c9c2d7 to ff86347 Compare March 13, 2024 10:34
Copy link

@georgewoodhead georgewoodhead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Just fix package name in changelog

CHANGELOG Outdated Show resolved Hide resolved
@rlh1994 rlh1994 force-pushed the release/snowplow-normalize/0.3.5 branch from ff86347 to f3c0daa Compare March 13, 2024 11:25
@rlh1994 rlh1994 merged commit 33a6aa4 into main Mar 18, 2024
7 checks passed
@rlh1994 rlh1994 deleted the release/snowplow-normalize/0.3.5 branch March 18, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants