-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/snowplow normalize/0.3.5 #40
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Coverage Report - Python 3.7
Python 3.7 Test Results
|
Test Coverage Report - Python 3.8
Python 3.8 Test Results
|
Test Coverage Report - Python 3.9
Python 3.9 Test Results
|
Test Coverage Report - Python 3.10
Python 3.10 Test Results
|
rlh1994
force-pushed
the
release/snowplow-normalize/0.3.5
branch
from
March 13, 2024 10:27
4407761
to
7c9c2d7
Compare
rlh1994
force-pushed
the
release/snowplow-normalize/0.3.5
branch
from
March 13, 2024 10:34
7c9c2d7
to
ff86347
Compare
georgewoodhead
approved these changes
Mar 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! Just fix package name in changelog
rlh1994
force-pushed
the
release/snowplow-normalize/0.3.5
branch
from
March 13, 2024 11:25
ff86347
to
f3c0daa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds schema grant support, adds missing arg in delete from manifest
What type of PR is this? (check all applicable)
Related Tickets & Documents
https://snplow.atlassian.net/browse/PE-5867
https://www.notion.so/keep-in-the-snow/Normalize-71c3ef79bb2d4db78271a310410e272e
Checklist
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?
Release Only Checklist