Add streaming BigQuery Loader modules #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbeemster
reviewed
Apr 4, 2024
main.tf
Outdated
| @@ -69,26 +65,13 @@ resource "google_project_iam_member" "sa_logging_log_writer" { | |||
| member = "serviceAccount:${google_service_account.sa.email}" | |||
| } | |||
|
|
|||
| //TODO do we need this? Or instead should we pass service account key as variable? | |||
There was a problem hiding this comment.
Yes but if you want to have an optional override for testing scenarios go for it!
jbeemster
reviewed
Apr 4, 2024
| } | ||
| } | ||
| %{ endif ~} |
There was a problem hiding this comment.
Please add the telemetry configs here!
jbeemster
reviewed
Apr 4, 2024
| %{ endif ~} | ||
| --mount type=bind,source=$${CONFIG_DIR},target=/snowplow/config \ | ||
| --env JDK_JAVA_OPTIONS='${java_opts}' \ | ||
| --env ACCEPT_LIMITED_USE_LICENSE=${accept_limited_use_license} \ |
There was a problem hiding this comment.
For telemetry to work you will need to add INSTANCE_ID as an env_var - see the other google OSS modules for examples.
jbeemster
reviewed
Apr 4, 2024
templates/startup-script.sh.tmpl
Outdated
| --mount type=bind,source=$${CONFIG_DIR},target=/snowplow/config \ | ||
| --env JDK_JAVA_OPTIONS='${java_opts}' \ | ||
| --env ACCEPT_LIMITED_USE_LICENSE=${accept_limited_use_license} \ | ||
| snowplow/bigquery-loader-pubsub:${version} \ |
jbeemster
reviewed
Apr 4, 2024
variables.tf
Outdated
| @@ -17,7 +17,7 @@ variable "name" { | |||
| variable "app_version" { | |||
| description = "App version to use. This variable facilitates dev flow, the modules may not work with anything other than the default value." | |||
| type = string | |||
| default = "1.7.0" | |||
| default = "2.0.0-rc4" | |||
There was a problem hiding this comment.
needs to be switched to a non-RC version before release
jbeemster
reviewed
Apr 4, 2024
| type = string | ||
| default = "" | ||
| } | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.