Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #227 : replace deprecated gallery by recycler view #305

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shiv07tiwari
Copy link

Fix #227

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with gradlew app:connectedGmsDebugAndroidTest to make sure you didn't break anything (with an emulator running or phone connected)

  • If you have multiple commits please combine them into one commit by squashing them.

Replaces deprecated Gallery by RecyclerVIew .

  • Improved performance
  • Better UI
  • Less empty screen

IMG_20190426_050225

@TacoTheDank
Copy link
Contributor

@jaydeetay I think this would be another good addition for the project. Gallery was deprecated in API 16 and is no longer supported.

@shiv07tiwari Would you be able to rebase this on the latest commit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace deprecated Gallery with the Horizontal Recycler View in Gallery section
2 participants