Added Code for required Icon #289
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sashrika Kaur <[email protected]>
jaydeetay
reviewed
Apr 28, 2019
| @@ -76,7 +76,7 @@ public ProtobufAstronomicalSource(AstronomicalSourceProto proto, Resources resou | |||
| if (names == null) { | |||
| names = new ArrayList<String>(proto.getNameIdsCount()); | |||
| for (int id : proto.getNameIdsList()) { | |||
| names.add(resources.getString(id)); | |||
| // names.add(resources.getString(id)); | |||
There was a problem hiding this comment.
Lots of changes in here that don't seem relevant.
jaydeetay
reviewed
Apr 28, 2019
| @@ -5,7 +5,7 @@ dependencies { | |||
| implementation project(path: ':app',configuration:'default') | |||
| implementation 'com.google.guava:guava:21.0' | |||
| // TODO(jontayler): Terrible hack that should go when we revamp the tools. | |||
| implementation files('../app/build/intermediates/classes/gms/release/') | |||
| implementation files('../app/build/intermediates/classes/') | |||
There was a problem hiding this comment.
The project did not build because it was not able to find some files. This fixed that issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Icon provided for Terms of Service mentioned in the TODO task.
Fixes #290