Bugfix/#2867 Fixes popup disappearing in Input Autocompete

[nullpointerexceptionkek]

Linked Issue

Closes #2867

Description

Fixes by checking if the current selection contains a text.

Changsets

Instructions: Changesets automate our changelog. If you modify files in /packages, run pnpm changeset in the root of the monorepo, follow the prompts, then commit the markdown file. Changes that add features should be minor while chores and bugfixes should be patch. Please prefix the changeset message with feat:, bugfix: or chore:.

Checklist

Please read and apply all contribution requirements.

• This PR targets the dev branch (NEVER master)
• Documentation reflects all relevant changes
• Branch is prefixed with: docs/, feat/, chore/, bugfix/
• Ensure Svelte and Typescript linting is current - run pnpm ci:check
• Ensure Prettier linting is current - run pnpm format
• All test cases are passing - run pnpm test
• Includes a changeset (if relevant; see above)

[changeset-bot]

🦋 Changeset detected

Latest commit: a7d5803

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@skeletonlabs/skeleton	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
skeleton-docs	✅ Ready (Inspect)	Visit Preview	Nov 8, 2024 8:42pm

[vercel]

@nullpointerexceptionkek is attempting to deploy a commit to the Skeleton Labs Team on Vercel.

A member of the Team first needs to authorize it.

[nullpointerexceptionkek]

Werid, the test works on my machine

[endigo9740]

@nullpointerexceptionkek we typically don't accept drive-by PRs like this. We rather folks discuss the changes upfront to verify they are changes we would accept. In this case, we have instituted a feature freeze on the v2 Popover feature.

I'll leave this for now to consider it, but cannot promise it'll move forward.

Also, if you would please ahead remove the issue #XXXX from the changeset. Changesets append this automatically, so this is redundant.

[nullpointerexceptionkek]

@nullpointerexceptionkek we typically don't accept drive-by PRs like this. We rather folks discuss the changes upfront to verify they are changes we would accept. In this case, we have instituted a feature freeze on the v2 Popover feature.

I'll leave this for now to consider it, but cannot promise it'll move forward.

Also, if you would please ahead remove the issue #XXXX from the changeset. Changesets append this automatically, so this is redundant.

Yes, I will make an update on this.

So the typical procedure is to discuss in the issue thread?

[endigo9740]

So the typical procedure is to discuss in the issue thread?

Or Discord, etc. Anything so we can ensure folks aren't wasting time on updates we won't accept! We're trying to help in that regard. This is covered in our contribution requirements:

https://www.skeleton.dev/docs/contributing/requirements#pull-requests

Given it's a small change I may allow it this once, but it'll be lower priority for now.