Assessment completed from Armando Jimenez #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erictruong-sv
added a commit
to erictruong-sv/keg-tech-assessment
that referenced
this pull request
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tasks are completed
I did have to update the package.json
in scripts > api
from
"api": "nodemon --watch ./server --watch ./configs --exec 'node ./server/index.js'",
to
"api": "npx nodemon --watch ./server --watch ./configs --exec "node ./server/index.js"",
this prevent the node is not recognized error
in server > server.js
line 34 I had to update the Access-Control-Allow-Origin for the API call to work
from
res.header('Access-Control-Allow-Origin', foundOrigin)
to
"res.header('Access-Control-Allow-Origin', "http://localhost:3000")"
foundOrigin kept comming up as undefined, and made the decisions to focus on the assignment