[Core] Move project to PCRE2 #2299
Conversation
Ansuel
force-pushed
the
pcre2-conversion
branch
from
95c6207
to
18d4a54
Compare
|
Unit-tests compilation failed: https://public-artifacts.signalwire.cloud/drone/signalwire/freeswitch/1547/unit-tests-build-result.txt |
|
Scan-build compilation failed: https://public-artifacts.signalwire.cloud/drone/signalwire/freeswitch/1547/scan-build-result.txt |
|
Unit-tests compilation failed: https://public-artifacts.signalwire.cloud/drone/signalwire/freeswitch/1548/unit-tests-build-result.txt |
Ansuel
force-pushed
the
pcre2-conversion
branch
from
18d4a54
to
d182344
Compare
|
Scan-build compilation failed: https://public-artifacts.signalwire.cloud/drone/signalwire/freeswitch/1548/scan-build-result.txt |
|
Unit-tests compilation failed: https://public-artifacts.signalwire.cloud/drone/signalwire/freeswitch/1549/unit-tests-build-result.txt |
Ansuel
force-pushed
the
pcre2-conversion
branch
from
d182344
to
e0ab191
Compare
|
Scan-build compilation failed: https://public-artifacts.signalwire.cloud/drone/signalwire/freeswitch/1549/scan-build-result.txt |
|
Unit-tests compilation failed: https://public-artifacts.signalwire.cloud/drone/signalwire/freeswitch/1550/unit-tests-build-result.txt |
|
Scan-build found bugs: https://public-artifacts.signalwire.cloud/drone/signalwire/freeswitch/1550/index.html |
Ansuel
force-pushed
the
pcre2-conversion
branch
from
e0ab191
to
7fc6994
Compare
|
Unit-tests compilation failed: https://public-artifacts.signalwire.cloud/drone/signalwire/freeswitch/1551/unit-tests-build-result.txt |
Ansuel
force-pushed
the
pcre2-conversion
branch
from
7fc6994
to
de6d3c5
Compare
|
Scan-build found bugs: https://public-artifacts.signalwire.cloud/drone/signalwire/freeswitch/1551/index.html |
|
Unit-tests compilation failed: https://public-artifacts.signalwire.cloud/drone/signalwire/freeswitch/1552/unit-tests-build-result.txt |
|
Scan-build found bugs: https://public-artifacts.signalwire.cloud/drone/signalwire/freeswitch/1552/index.html |
Ansuel
force-pushed
the
pcre2-conversion
branch
from
de6d3c5
to
583788b
Compare
|
Scan-build found bugs: https://public-artifacts.signalwire.cloud/drone/signalwire/freeswitch/1553/index.html |
Ansuel
force-pushed
the
pcre2-conversion
branch
from
583788b
to
8e3e513
Compare
|
Unit-tests compilation failed: https://public-artifacts.signalwire.cloud/drone/signalwire/freeswitch/1554/unit-tests-build-result.txt |
|
Scan-build compilation failed: https://public-artifacts.signalwire.cloud/drone/signalwire/freeswitch/1554/scan-build-result.txt |
Ansuel
force-pushed
the
pcre2-conversion
branch
4 times, most recently
from
8506bdf
to
1b8ccba
Compare
|
Unit-tests compilation failed: https://public-artifacts.signalwire.cloud/drone/signalwire/freeswitch/1555/unit-tests-build-result.txt |
|
Scan-build compilation failed: https://public-artifacts.signalwire.cloud/drone/signalwire/freeswitch/1555/scan-build-result.txt |
Ansuel
force-pushed
the
pcre2-conversion
branch
from
d0aff0a
to
2ba56eb
Compare
|
Scan-build found bugs: https://public-artifacts.signalwire.cloud/drone/signalwire/freeswitch/1564/index.html |
Ansuel
force-pushed
the
pcre2-conversion
branch
2 times, most recently
from
42162a8
to
6b59763
Compare
|
Well took me a bit to fix all the hiccups so sorry for the mass force push and stuff... Problem with windows related thing still apply... |
Ansuel
force-pushed
the
pcre2-conversion
branch
from
6b59763
to
fc07bcc
Compare
Ansuel
force-pushed
the
pcre2-conversion
branch
from
fc07bcc
to
40562d9
Compare
Ansuel
force-pushed
the
pcre2-conversion
branch
from
40562d9
to
b0692d4
Compare
Ansuel
force-pushed
the
pcre2-conversion
branch
from
b0692d4
to
dd2e0bf
Compare
|
@andywolk any news with this? |
|
@dragos-oancea @andywolk Any chance someone can look at this? This is one of the few remaining package that still depends on PCRE and we are trying to drop PCRE on openwrt. Most of the changes as simple and straight migration from PCRE to PCRE2. |
|
Guys, kind reminder. 2 weeks passed. This PR is here since 3rd November. @jakubkarolczyk Any chance to review this, please? |
|
Ping |
|
That first commit could probably go as a separate fix regardless. |
|
I could also reswig master so this PR does not have to have that swig commit. |
|
The swig commit in this PR is not required. |
For mod_verto regex was never freed and was actually leaking memory. Correctly free the compiled regex to fix the memory leak. Signed-off-by: Christian Marangi <[email protected]>
Move project to PCRE2 as PCRE is EOL and won't receive any security updates anymore. PCRE2 have different API compared to PCRE. Mainly PCRE2 have the concept of match_data, no ovector needs to be passed, different handling for error string and different handling for substring manipulation. Update any user of PCRE library with the new API Signed-off-by: Christian Marangi <[email protected]>
Ansuel
force-pushed
the
pcre2-conversion
branch
from
dd2e0bf
to
b87c179
Compare
|
@andywolk I split the fix commit in a separate PR. I will drop the commit from here once it's merged. Thanks a lot for the followup |
|
@andywolk BTW is also produced this alternative version Ansuel@60ad581 This doesn't cause ANY change in the current API but have some hacks in mind:
Honestly the HACK are big enough to really justify new API but that requires as you notice making any module that might use switch regex incompatible :( Maybe it's possible to propose to PCRE2 devs to introduce some additional API to construct a match_data externally (that is really what we need) but I doubt the would accept something like that. For sure a big reason might be that, that single change permits an almost 1:1 translation of old PCRE API to the new one. |
Move project to PCRE2 as PCRE is EOL and won't receive any security
updates anymore.
PCRE2 have different API compared to PCRE. Mainly PCRE2 have the concept
of match_data, no ovector needs to be passed, different handling for
error string and different handling for substring manipulation.
Update any user of PCRE library with the new API
Signed-off-by: Christian Marangi [email protected]
This also have 2 bugfix that i found while doing the conversion..
Codewise I should have ported anything... What I need help is in the visual studio project files and some other small thing... Hope someone can help with them!