Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify ApiKey entity by exposing key as a readonly prop #2248

Merged

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented Nov 4, 2024

Part of #2193

Remove toString and __toString methods from ApiKey entity, and instead expose key as a public readonly property.

This will simplify finding all usages of key in future, when the key becomes a hash of the actual key.

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.53%. Comparing base (3085fa7) to head (79c5418).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2248      +/-   ##
=============================================
- Coverage      93.54%   93.53%   -0.01%     
+ Complexity      1613     1611       -2     
=============================================
  Files            270      270              
  Lines           5635     5631       -4     
=============================================
- Hits            5271     5267       -4     
  Misses           364      364              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acelaya acelaya merged commit e4fe7ad into shlinkio:develop Nov 4, 2024
31 checks passed
@acelaya acelaya deleted the feature/api-key-simplification branch November 4, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant