Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PHP 8.3 #1907

Merged
merged 3 commits into from
Nov 4, 2023
Merged

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented Nov 4, 2023

Closes #1905

This PR adds initial support for PHP 8.3, by running pipelines in that PHP version as well.

For now, pipelines running on PHP 8.3 are allowed to fail/continue on error, until all project direct dependencies support PHP 8.3

Copy link

codecov bot commented Nov 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2a782ab) 96.73% compared to head (32f465f) 96.73%.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #1907   +/-   ##
==========================================
  Coverage      96.73%   96.73%           
  Complexity      1306     1306           
==========================================
  Files            244      244           
  Lines           4530     4530           
==========================================
  Hits            4382     4382           
  Misses           148      148           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acelaya acelaya merged commit d9d6d5b into shlinkio:develop Nov 4, 2023
32 of 33 checks passed
@acelaya acelaya deleted the feature/php-8.3 branch November 4, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for PHP 8.3
1 participant