Skip to content

Commit

Permalink
Merge pull request #24 from sherpal/master
Browse files Browse the repository at this point in the history
Publish fix by JakeWhite2
  • Loading branch information
sherpal authored Sep 21, 2022
2 parents 6d18675 + 36c4e54 commit 8f02a83
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 8 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ libraryDependencies ++= List(

where `<release-tag>` must be replaced with any of the release tags from [here](https://github.com/sherpal/LaminarSAPUI5Bindings/releases). Note that it is correctly defined with single `%`. This thing using Jitpack which I'm not sure I understand, but it works like that.

The relase tag is composed of the version of the project, followed by the (beginning of the) commit hash that issued the release.
The release tag is composed of the version of the project, followed by the (beginning of the) commit hash that issued the release.

The version of the project corresponds to the version of the SAP UI5 version of the libraries these bindings are made for. Using these bindings with an earlier version will probably show stuff that did not exist at the time. Similarly, using these bindings with an older version will imply that you will not find certain bindings. **Other than that, it is perfectly safe to mix mismatch versions.**

Expand Down Expand Up @@ -285,4 +285,4 @@ You will then need to fill the `component` def. You should make use of the `Demo

You then need to add your example in the list in the `EntryPoint` in the `demo` package.

For the strucutre, you can take inspiration from the existing other examples. For the content of your demo, you can take inspiration from the official SAP docs.
For the structure, you can take inspiration from the existing other examples. For the content of your demo, you can take inspiration from the official SAP docs.
2 changes: 1 addition & 1 deletion demo/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion demo/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@
"@ui5/webcomponents": "1.3.0",
"@ui5/webcomponents-fiori": "1.3.0",
"@ui5/webcomponents-icons": "1.3.0",
"highlight.js": "11.6.0"
"highlight.js": "^11.6.0"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -18,17 +18,13 @@ final class Slot(name: String) {

private val slot: ReactiveHtmlAttr[String] = customHtmlAttr("slot", StringAsIsCodec)

@targetName("fixedSlot")
def :=(element: HtmlElement): Inserter[Base] = <--(Val(element.amend(slot := name)))

@targetName("fixedSlot")
def :=(elements: Seq[HtmlElement])(using DummyImplicit): Inserter[Base] = <--(Val(elements))

@targetName("slotObservable")
def <--(elementObservable: Observable[HtmlElement]): Inserter[Base] =
child <-- elementObservable.map(_.amend(slot := name))

@targetName("slotObservable")
def <--(elementsObservable: Observable[Seq[HtmlElement]])(using DummyImplicit): Inserter[Base] =
children <-- elementsObservable.map(_.map(_.amend(slot := name)))

Expand Down

0 comments on commit 8f02a83

Please sign in to comment.