Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compile without needing checkouts for gamma and gamma-driver #18

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

grav
Copy link

@grav grav commented Nov 6, 2016

This PR based on a fork from @xeqi

To use the gamma and gamma-driver jars, I've guessed a few gamma api changes:

  • gamma.api/pow is now gamma.api/power
  • more speculative, gamma-driver.drivers.basic/default-produce-fn is now gamma-driver.drivers.basic/produce

Everything compiles, and the examples seem to run in Safari and Chrome Canary

xeqi and others added 3 commits June 6, 2015 15:59
So this is a big commit.  It has in it:

1. Remove lessons that are majorly broken (hopefully can remerge in from upstream)
2. Fix lessons that have minor brokeness
3. Remove the current reloading mechanisms
4. Rewrite the dev/test/prod setup to use user.clj and a component arch
5. Cleanup project.clj into a minimal version
6. Require checkouts for gamma and gamma-driver

The dev environment works mostly well.  It starts in the user namespace
and functions `go` `reset` `browser-repl` and `fig-status` work. Since this
uses a component arch, reloading clj files is done by calling `reset`.

There is one complication with `reset`, in that http-kit does not close websockets
when it is stopped.  This causes figwheel's liveness pings to error. To prevent
this basically requires closing the browser tab.

Testing now works as well.

Unfortunatly production is not tested yet. `lein uberjar` does not allow checkouts,
so this requires waiting until a new gamma and gamma driver are released.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants