Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support streaming iteration over sequences #760

Closed
wants to merge 4 commits into from
Closed

Support streaming iteration over sequences #760

wants to merge 4 commits into from

Conversation

leo60228
Copy link

@leo60228 leo60228 commented Mar 9, 2021

Closes #404

This makes it possible to get a SeqAccess outside of a Visitor implementation, and provides a wrapper implementing Iterator for convenience.

@leo60228
Copy link
Author

leo60228 commented Mar 9, 2021

Ugh, I completely forgot that serde had such a low MSRV...

dtolnay
dtolnay reviewed Mar 9, 2021
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

This looks generally equivalent to #653, so I would prefer not to accept it for the same reason.

@dtolnay dtolnay closed this Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide a way for StreamDeserializer to stream an array of values
2 participants
@leo60228 @dtolnay