Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce how much code is generated #745

Open
wants to merge 34 commits into
base: master
Choose a base branch
from
Open

Reduce how much code is generated #745

wants to merge 34 commits into from

Commits on Jul 4, 2022

  1. refactor: Factor out whitespace skipping into helpers 

    Should hopefully reduce the amount of code being generated
    Markus Westerlind authored and Markus Westerlind committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    1a739c1 View commit details
    Browse the repository at this point in the history

  2. refactor: Add next_char_or_error

    Markus Westerlind authored and Markus Westerlind committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    b01ff91 View commit details
    Browse the repository at this point in the history

  3. Move more non-generic code out of the generic path

    Markus Westerlind authored and Markus Westerlind committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    fcd4dc1 View commit details
    Browse the repository at this point in the history

  4. Move eat_char into the _until function

    Markus Westerlind authored and Markus Westerlind committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    57dc798 View commit details
    Browse the repository at this point in the history

  5. Move even more code out of the generic deserialize_struct

    Markus Westerlind authored and Markus Westerlind committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    b9540a7 View commit details
    Browse the repository at this point in the history

  6. Move recursion checking out of the generic path

    Markus Westerlind authored and Markus Westerlind committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    3e0d096 View commit details
    Browse the repository at this point in the history

  7. Factor out non-generic parts of next_element_seed

    Markus Westerlind authored and Markus Westerlind committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    b63097f View commit details
    Browse the repository at this point in the history

  8. Factor out non-generic parts of next_key_seed

    Markus Westerlind authored and Markus Westerlind committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    3c327b0 View commit details
    Browse the repository at this point in the history

  9. Use try_with!

    Markus Westerlind authored and Markus Westerlind committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    4e98512 View commit details
    Browse the repository at this point in the history

  10. Move non-generic code out of deserialize_any

    Markus Westerlind authored and Markus Westerlind committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    e6216e6 View commit details
    Browse the repository at this point in the history

  11. s/field/element/

    Markus Westerlind authored and Markus Westerlind committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    1ca5734 View commit details
    Browse the repository at this point in the history

  12. Avoid using map in generic functions

    Markus Westerlind authored and Markus Westerlind committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    061247b View commit details
    Browse the repository at this point in the history

  13. refactor: Add helpers for serializing begin/end key/object 

    Avoids generating duplicates of the map_err per key/value type
    Markus Westerlind authored and Markus Westerlind committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    52259b9 View commit details
    Browse the repository at this point in the history

  14. Move out code from the generic string deserialization methods

    Markus Westerlind authored and Markus Westerlind committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    87d36a5 View commit details
    Browse the repository at this point in the history

  15. Shrink deserialize_struct a bit more

    Markus Westerlind authored and Markus Westerlind committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    322f8c4 View commit details
    Browse the repository at this point in the history

  16. refactor: Factor out the duplicated variant serialization

    Markus Westerlind authored and Markus Westerlind committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    5d5ad07 View commit details
    Browse the repository at this point in the history

  17. refactor: add begin/end_string helpers

    Markus Westerlind authored and Markus Westerlind committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    33ef802 View commit details
    Browse the repository at this point in the history

  18. refactor: Avoid a tri! in commonly instantiated code

    Markus Westerlind authored and Markus Westerlind committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    5cf7a6f View commit details
    Browse the repository at this point in the history

  19. refactor: Various shortenings

    Markus Westerlind authored and Markus Westerlind committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    cacd1b7 View commit details
    Browse the repository at this point in the history

  20. Further extract code out of deserialize_any

    Markus Westerlind authored and Markus Westerlind committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    6fd698c View commit details
    Browse the repository at this point in the history

  21. refactor: Extract parse_option

    Markus Westerlind authored and Markus Westerlind committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    9f16c61 View commit details
    Browse the repository at this point in the history

  22. Shorten unit deserializing

    Markus Westerlind authored and Markus Westerlind committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    d28a020 View commit details
    Browse the repository at this point in the history

  23. Extract helpers to reduce map_err calls

    Markus Westerlind authored and Markus Westerlind committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    f77905a View commit details
    Browse the repository at this point in the history

  24. refactor: Remove unnecessary tri! calls

    Markus Westerlind authored and Markus Westerlind committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    760ccb2 View commit details
    Browse the repository at this point in the history

  25. refactor: Extract a less generic part of deserialize_number

    Markus Westerlind authored and Markus Westerlind committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    9956638 View commit details
    Browse the repository at this point in the history

  26. refactor: Extract code from deserialize_enum

    Markus Westerlind authored and Markus Westerlind committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    0f15688 View commit details
    Browse the repository at this point in the history

  27. refactor: De-duplicate the recursion checking

    Markus Westerlind authored and Markus Westerlind committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    60cdfbd View commit details
    Browse the repository at this point in the history

  28. Add an OptionResult enum

    Markus Westerlind authored and Markus Westerlind committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    4de41fd View commit details
    Browse the repository at this point in the history

  29. inline

    Markus Westerlind authored and Markus Westerlind committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    9e56187 View commit details
    Browse the repository at this point in the history

  30. Extract prefixes for deserialize_seq and map

    Markus Westerlind authored and Markus Westerlind committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    010eb7c View commit details
    Browse the repository at this point in the history

  31. Reuse Deserialzer::parse_str

    Markus Westerlind authored and Markus Westerlind committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    2067058 View commit details
    Browse the repository at this point in the history

  32. Remove end_map, end_seq

    Markus Westerlind authored and Markus Westerlind committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    0fa7a8f View commit details
    Browse the repository at this point in the history

  33. Fix check_recursion_prefix

    Markus Westerlind authored and Markus Westerlind committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    f595267 View commit details
    Browse the repository at this point in the history

  34. Fix clippy

    Markus Westerlind authored and Markus Westerlind committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    60e4ac2 View commit details
    Browse the repository at this point in the history