feat: makefile project engineering design and build design #2161
Conversation
github-actions
bot
added
the
ImageBuilding
Codecov ReportPatch coverage has no change and project coverage change:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #2161 +/- ##
==========================================
- Coverage 19.93% 8.77% -11.17%
==========================================
Files 98 165 +67
Lines 9220 13805 +4585
==========================================
- Hits 1838 1211 -627
- Misses 7128 12438 +5310
+ Partials 254 156 -98
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
rebase to serval commits |
cubxxw
force-pushed
the
feature/makefile-super
branch
from
209813e
to
0736b65
Compare
|
@cubxxw Cloud you please add more description for this PR? |
Signed-off-by: Xinwei Xiong(cubxxw) <[email protected]>
makefile:What is needed to preserve it save makefile add makefile go.build as dirty Add the images and copyright portions of the makefile Clear the output directory to tools.clean add help info for samll makefile Signed-off-by: Xinwei Xiong(cubxxw) <[email protected]> The help information is built End help, Color and case Complete the makefile tools section Finish implementing the code generator Initialize Initialize the contributor file Remove some irrelevant directories Signed-off-by: Xinwei Xiong(cubxxw) <[email protected]>
Signed-off-by: Xinwei Xiong(cubxxw) <[email protected]>
Signed-off-by: Xinwei Xiong(cubxxw) <[email protected]>
Signed-off-by: Xinwei Xiong(cubxxw) <[email protected]>
Signed-off-by: Xinwei Xiong(cubxxw) <[email protected]> fix: part about build issues Signed-off-by: Xinwei Xiong(cubxxw) <[email protected]> fix: part about build issues Signed-off-by: Xinwei Xiong(cubxxw) <[email protected]>
… of the script Signed-off-by: Xinwei Xiong(cubxxw) <[email protected]>
Signed-off-by: Xinwei Xiong(cubxxw) <[email protected]>
cubxxw
force-pushed
the
feature/makefile-super
branch
from
aea8446
to
d0ef7e1
Compare
cubxxw
changed the title
|
After completing the basic tests, I will create a design document in the form of Google Docs and sync it to an issue. |
Signed-off-by: Xinwei Xiong(cubxxw) <[email protected]>
Signed-off-by: Xinwei Xiong(cubxxw) <[email protected]>
Signed-off-by: Xinwei Xiong(cubxxw) <[email protected]>
| # sealer build use BUILD_TOOLS | ||
| BUILD_TOOLS ?= golangci-lint goimports addlicense deepcopy-gen conversion-gen ginkgo go-junit-report | ||
| # Code analysis tools | ||
| ANALYSIS_TOOLS = golangci-lint goimports golines go-callvis kube-score |
There was a problem hiding this comment.
do we need all those tools ?
| # docker registry: registry.example.com/namespace/image:tag as: registry.hub.docker.com/cubxxw/<image-name>:<tag> | ||
| # | ||
|
|
||
| DOCKER := docker |
There was a problem hiding this comment.
what does this image.mk do? do we need it ?
| } | ||
| //TODO! | ||
| // missinfo := []string{} | ||
| // if OutputInfo.KubernetesVersion == nil { |
There was a problem hiding this comment.
version just show sealer git info. no need to include cluster info. or we can support it later by using another cmd.
| return versionCmd | ||
| } | ||
|
|
||
| func PrintInfo() error { |
There was a problem hiding this comment.
could we split those code optimization from this pr
Signed-off-by: Xinwei Xiong(cubxxw) [email protected]
Describe what this PR does / why we need it
Does this pull request fix one issue?
Fixes #2148
Describe how you did it
Describe how to verify it
Special notes for reviews