saving container image optional #1851
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YTGhost
force-pushed
the
saving-container-image-optional
branch
from
23dcc5a
to
8e41a35
Compare
kakaZhou719
reviewed
Nov 11, 2022
YTGhost
force-pushed
the
saving-container-image-optional
branch
from
8e41a35
to
87643e8
Compare
Codecov ReportBase: 21.65% // Head: 21.65% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #1851 +/- ##
=======================================
Coverage 21.65% 21.65%
=======================================
Files 72 72
Lines 6586 6586
=======================================
Hits 1426 1426
Misses 4974 4974
Partials 186 186 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: HIHIA <[email protected]>
YTGhost
force-pushed
the
saving-container-image-optional
branch
from
87643e8
to
a834725
Compare
starnop
reviewed
Nov 15, 2022
| @@ -92,6 +92,7 @@ func NewBuildCmd() *cobra.Command { | |||
| buildCmd.Flags().StringSliceVar(&buildFlags.Annotations, "annotation", []string{}, "add annotations for image. Format like --annotation key=[value]") | |||
| buildCmd.Flags().StringSliceVar(&buildFlags.Labels, "label", []string{getSealerLabel()}, "add labels for image. Format like --label key=[value]") | |||
| buildCmd.Flags().BoolVar(&buildFlags.NoCache, "no-cache", false, "do not use existing cached images for building. Build from the start with a new set of cached layers.") | |||
| buildCmd.Flags().BoolVarP(&buildFlags.DownloadContainerImage, "download-container-image", "d", true, "save the container image generated during the build process.") | |||
There was a problem hiding this comment.
how about adding a new flag like buildMode?
And different build mode means different logic of execution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Does this pull request fix one issue?
Fixes #1849
Describe how you did it
Describe how to verify it
Special notes for reviews