Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Image Lab React]:Added preload scripts to use ipcRenderer. #179

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

achyutagupta
Copy link

@achyutagupta achyutagupta commented Jan 11, 2024

Description

I have added preload scripts to fix the error window.require is not a function.
The preload script initialize the renderer process environment i.e,ipcRenderer before the actual web page content is loaded.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

Initially it was giving this error,

require2

After adding preload scripts,

resolved

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@abdullahranginwala
Copy link
Contributor

@achyutagupta everything seems good! The maintainers will review and merge the PR accordingly.

Thank you for contributing!

@achyutagupta
Copy link
Author

@abdullahranginwala Your Welcome!
Looking forward to do more similar contributions in future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Image Lab React] window.require is not a function.
2 participants