Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added functionality in edge-detection operators #133

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

abdullahranginwala
Copy link
Contributor

Description

Earlier, there were two categories of operations:

  • Sobel Derivatives
  • Transformation

All the operators within these category had no functionality. Hence, I have merged the operators into one category named 'Edge Detection' which seems more appropriate. I've added functionality for all the operators using object oriented principles.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • [ x ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Manual Testing

Also, include screenshots for verification and reviewing purpose.

imagelab.edge.detection.mov
imagelab.edge.detection.mov

Checklist:

  • [ x ] My code follows the style guidelines of this project
  • [ x ] I have performed a self-review of my code
  • [ x ] I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [ x ] My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@SahanDisa
Copy link
Collaborator

@abdullahranginwala There is some issue with this branch. Have you rebased for a different commit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants