-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Label styles, LabelBackground #78
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mggower
force-pushed
the
feature/label-styles
branch
2 times, most recently
from
November 2, 2023 15:45
1b7ec97
to
affae79
Compare
mggower
changed the title
Label styles, LabelBackground, and updated examples dir
Label styles, LabelBackground
Nov 6, 2023
jameslaneconkling
approved these changes
Nov 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
at some point would be good to align the interface for all the objects. i.e. make sure the rules around what setup work is done in the constructor is consistent, and ditto how update/moveTo and what the rules are on when to invoke them.
jameslaneconkling
requested changes
Nov 6, 2023
mggower
force-pushed
the
feature/label-styles
branch
from
November 6, 2023 20:44
f13a881
to
83d44c9
Compare
jameslaneconkling
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Label styling
Label class
FontBook
class so unused fonts are uninstalledupdate
methodmoveTo
methodLabel Background class
Label
class directlyupdate
andmoveTo
methodsTODO: write some documentation for the above changes and styling options
_screenshot from examples/native/labels_