merge dep changes to pixi-v7 branch #71
Conversation
…ad only get properties
This reverts commit 8d5fbd8.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
package.json
Outdated
| "dist" | ||
| ], | ||
| "source": "src/index.umd.ts", | ||
| "main": "./legacy/main.js", |
There was a problem hiding this comment.
rather than name the umd directory legacy let's just name it umd (umd is just a different module format, but isn't necessarily legacy or meant to work only w/ older browsers. e.g. we introduced it to work w/ the code sandbox we were using to host examples b/c that was easier than getting it to work w/ npm directly). and it looks like the umd build output is index.js not main.js, so just need to be ./dist/umd/index.js
There was a problem hiding this comment.
also, not positive, but I think types needs to be ./dist/index.d.ts.
There was a problem hiding this comment.
finally, rather than main/module, should we use get rid of main and module and just use exports? https://nodejs.org/api/packages.html#package-entry-points
package.json
Outdated
| @@ -2,13 +2,10 @@ | |||
| "name": "@sayari/trellis", | |||
| "version": "0.7.0-rc.0", | |||
There was a problem hiding this comment.
this should be bumped to whatever the current rc tag is
package.json
Outdated
| "d3-color": "^3.1.0", | ||
| "d3-force": "^3.0.0", | ||
| "d3-hierarchy": "^3.1.2", | ||
| "d3-interpolate": "^3.0.1", | ||
| "fontfaceobserver": "^2.1.0", | ||
| "pixi.js-legacy": "^6.5.5" | ||
| "parcel": "^2.9.3", | ||
| "pixi.js": "^7.2.4", |
There was a problem hiding this comment.
we should only ship with one version of pixi, probably pixi.js-legacy. though note that I haven't checked if any of my new renderer stuff works w/ Canvas... if it doesn't/can't, then publishing this w/ the pixi-legacy canvas fallback isn't worth it.
package.json
Outdated
| "author": "James Conkling <[email protected]> jameslaneconkling.github.io", | ||
| "license": "ISC", | ||
| "dependencies": { | ||
| "@pixi/unsafe-eval": "^6.5.5", | ||
| "@pixi/events": "^6.5.10", | ||
| "@pixi/unsafe-eval": "^6.5.10", |
There was a problem hiding this comment.
I think this needs to track the pixi.js version, 7.2.4
| "examples:dev": "npm run clean && parcel examples/index.html", | ||
| "docs:dev": "npm run clean && parcel docs-src/index.html", | ||
| "docs:build": "rm -rf ./docs/ && parcel build ./docs-src/index.html --dist-dir docs/ --public-url https://sayari-analytics.github.io/trellis/ && cp ./docs-src/assets/og-image.png ./docs/" | ||
| }, | ||
| "targets": { |
There was a problem hiding this comment.
I also think we can get rid of targets. this is a parcel-specific thing, but again, parcel only comes in to play w/ the umd build, which just targets the single entrypoint file ./src/index.umd.ts
No description provided.