NetApp replica promote: guard source being down #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Constructing a vserver client to the old active replica may fail in a disaster scenario. Promoting the non-active replica must work nevertheless. Change-Id: Ib1a36f45ba47e378e13acd24ea16634ed96e15ca
Carthaca
force-pushed
the
guard_orig_active_replica
branch
from
c20d39b
to
28bf9bf
Compare
chuan137
reviewed
Oct 24, 2023
| LOG.exception(msg, replica['id']) | ||
| return replica | ||
| except netapp_api.NaApiError: | ||
| # Catch everything! The original source may be down, |
There was a problem hiding this comment.
I am wondering is such a disaster situation, there is better way to handle it than error it out. Can we forcefully cut the old snapmirror relationships and elect the new replica? It might be helpful when there are more than two replicas
maybe we can drill down into the change_snapmirror_source() method
maybe add a comment for later to improve
The 'aborting' takes a while until snapmirror break can continue, give it 2 minutes at most. Change-Id: I0b411a00ab1fd72756e60e64cd9a71482a7998be
Carthaca
force-pushed
the
guard_orig_active_replica
branch
from
b0a77b3
to
ae878ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Constructing a vserver client to the old active replica
may fail in a disaster scenario. Promoting the non-active
replica must work nevertheless.
Change-Id: Ib1a36f45ba47e378e13acd24ea16634ed96e15ca