Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SECURITY] Fix Temporary Directory Hijacking or Information Disclosure Vulnerability #65

Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions src/main/java/tahrir/tools/TrUtils.java
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@

import java.io.*;
import java.lang.reflect.Type;
import java.nio.file.Files;
import java.security.interfaces.RSAPrivateKey;
import java.security.interfaces.RSAPublicKey;
import java.util.Random;
Expand Down Expand Up @@ -162,13 +163,7 @@ public static BroadcastMessage getBroadcastMessageFrom(TrNode node, UserIdentity
public static File createTempDirectory() throws IOException {
final File temp;

temp = File.createTempFile("temp", Long.toString(System.nanoTime()));

if (!(temp.delete()))
throw new IOException("Could not delete temp file: " + temp.getAbsolutePath());

if (!(temp.mkdir()))
throw new IOException("Could not create temp directory: " + temp.getAbsolutePath());
temp = Files.createTempDirectory("temp" + Long.toString(System.nanoTime())).toFile();

return (temp);
}
Expand Down