Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

salt/state.py: support retry: True as per docs #67049

Open
wants to merge 1 commit into
base: 3006.x
Choose a base branch
from

Conversation

tomdoherty
Copy link

@tomdoherty tomdoherty commented Nov 8, 2024

What does this PR do?

What issues does this PR fix or reference?

Fixes #67048

Previous Behavior

Below warning displayed when valid option retry: True used

[WARNING ] State is set to retry, but a valid dict for retry configuration was not found.  Using retry defaults

New Behavior

No warning shown. Defaults used as documented

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes/No

Please review Salt's Contributing Guide for best practices, including the
PR Guidelines.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@tomdoherty tomdoherty requested a review from a team as a code owner November 8, 2024 10:43
@tomdoherty tomdoherty force-pushed the tomdoherty-state-retry-nag branch 3 times, most recently from 8fcd159 to 0beec24 Compare November 8, 2024 11:03
@twangboy
Copy link
Contributor

Once we get the testing pipeline finished we'll need you to rebase so that we can run the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants