Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3006.x] fix salt.ufw path in firewall.rst #67019

Open
wants to merge 3 commits into
base: 3006.x
Choose a base branch
from

Conversation

Xenon-Blu
Copy link

What does this PR do?

Fixes hyperlink path for the salt.ufw file in the Firewalls tutorial page

What issues does this PR fix or reference?

Broken hyperlink on tutorial page for firewalls

Previous Behavior

Points to https://github.com/saltstack/salt/blob/master/pkg/salt.ufw, which is a dead link

New Behavior

Points to https://github.com/saltstack/salt/blob/master/pkg/common/salt.ufw, which is the intended file

Merge requirements satisfied?

Commits signed with GPG?

Yes

@Xenon-Blu Xenon-Blu requested a review from a team as a code owner October 30, 2024 16:07
@dmurphy18
Copy link
Contributor

@Xenon-Blu This PR requires a changelog entry and tests

@dmurphy18 dmurphy18 self-requested a review October 30, 2024 19:42
@dmurphy18 dmurphy18 added this to the Sulfur v3006.10 milestone Oct 30, 2024
@Xenon-Blu Xenon-Blu marked this pull request as draft October 30, 2024 21:00
@Xenon-Blu
Copy link
Author

I am new to GitHub's test suite and not sure what kind of unit test this fix needs, but I made a changelog entry. Could I have assistance with continuing this? This is my first contribution here and I am happy to learn!

@Xenon-Blu Xenon-Blu marked this pull request as ready for review October 31, 2024 18:16
Copy link
Contributor

@twangboy twangboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is documentation, it doesn't need tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants