New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: shape name in create lockup #1094

Open

smol-ninja wants to merge 1 commit into staging from feat/emit-shape-name

Member

smol-ninja commented Nov 22, 2024 •

edited

Loading

Closes #1086.

I did not fuzz shape names in Fork and Invariant tests since its only emitted in event. So, concrete tests and fuzz tests are sufficient imo.
Re HTML injection attacks, a 32 bytes restriction on shape name has been applied.
The variable in the input parameter is called shape and not shapeName as I suppose the "name" keyword is implicit given that its a string type


          feat: shape name in create lockup

c121ee9

smol-ninja requested review from PaulRBerg and andreivladbrg

November 22, 2024 10:45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet