CI: Adapt Homebrew Cask generation #1637
Merged
+9
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Finii
force-pushed
the
feature/update-cask-generation
branch
from
788a1f1
to
b553aa8
Compare
|
Running the scripts locally looks good:
|
4 tasks
[why] The Cask-fonts repo has been incorporated into the main Cask repo. On releases we would use an obsolete repository to create the Cask into. The casks are now in a dedicated subdirectory (Casks/font) and under that we have one subdirectory for each font name starting character (to have a smaller number of files per directory I assume). [how] Change the repository path. Put part of the new (longer) path, the fixed part, just in the CI process, while the generator script takes care about the one-directory-per-startchar substructure. Fixes: #1635 Signed-off-by: Fini Jastrow <[email protected]>
Finii
force-pushed
the
feature/update-cask-generation
branch
from
b553aa8
to
f420373
Compare
|
Rebase on master, force push |
|
PR created: Homebrew/homebrew-cask#192468 Unfortunately some glitches, so did some hand-adjustments. This needs to be addressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[why]
The Cask-fonts repo has been incorporated into the main Cask repo. On releases we would use an obsolete repository to create the Cask into.
The casks are now in a dedicated subdirectory (
Casks/font) and under that we have one subdirectory for each font name starting character (to have a smaller number of files per directory I assume).[how]
Change the repository path.
Put part of the new (longer) path, the fixed part, just in the CI process, while the generator script takes care about the one-directory-per-startchar substructure.
Fixes: #1635
Requirements / Checklist
Issue number where discussion took place: #xxx
What does this Pull Request (PR) do?
Update the Cask generation and workflow to the upstream (or is that downstream) architectural changes.
How should this be manually tested?
Let the workflow run and examine the resulting PR, then close the PR :-D
Well, we need some change in our repo that causes the casks to differ or the PR will be empty.
Any background context you can provide?
What are the relevant tickets (if any)?
Screenshots (if appropriate or helpful)