-
-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make lite working on FreeBSD #127
base: master
Are you sure you want to change the base?
Conversation
1dfc5e0
to
f7412f9
Compare
@rxi Hi, I've just updated this PR as there was a conflict in I was wondering if you had any remarks on this patch. How can I make sure this gets merged? Is it something you want to merge? Thanks. |
Sorry about the delay! I haven't had a chance to grab this and look through it properly, from an initial skim I was a bit confused by use of the Overall I have a little bit of scepticism as this feels like it closely mimics the original path detection lite used (you'll have to look back at the initial commit) which unfortunately didn't work properly, (I believe, if you launched |
f7412f9
to
64bbcdc
Compare
I've removed the usage of As for the usage of |
1e74b7d
to
220c5bc
Compare
@rxi: Did you have any chance yet to review this pull request properly? You said you wanted to test this before you merge it. How can I help so this pull request gets merged? :-) Thanks |
+1 Taking a quick look at the proposed changes, they seem reasonable to me. |
clang and gcc both expose cc, so that should be used. bash doesn't have to be installed at /bin/bash, even on certain Linux distributions
SDL2 is only available at a non-default path on some systems. pkgconf, when installed, may help in those cases
220c5bc
to
5d800b3
Compare
It turns out using argv[0] is a bad idea. This uses sysctl() to retrieve its own path
This PR makes
lite
working on FreeBSD, by fixing up build.sh and add proper path detection support on FreeBSD.Note that I use
realpath
on FreeBSD.realpath
is also available under Linux, but only when_DEFAULT_SOURCE
is defined. I'm not going to change path detection on Linux, as it seems to work and you probably had a good reason to use/proc
directly.I didn't change
build_release.sh
, as I'm not using it at all. I leave it up to you to change it if you so desire.