Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cargo.toml #2868

Open
wants to merge 1 commit into
base: v0.5
Choose a base branch
from
Open

Update Cargo.toml #2868

wants to merge 1 commit into from

Conversation

Dylan-DPC
Copy link

Bumps the dependency to at least 2.2.3 as per the advisory

Advisory

(even though this crate may not be using the function mentioned in the advisory, it is better to bump it to ensure that there is no chance of other dependencies pulling it)

@the10thWiz
Copy link
Collaborator

It's unclear to me that this brings significant benefit to Rocket users. Rocket already enforces data limits for user requests, so it's highly unlikely a problematic sql query could be built from a Rocket request.

The main issue with upgrading right away, is that we also need a compatible version of diesel-async, which supports the newest version diesel. This is noted in the CI failures as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants