fix #326 (help-wanted) #365
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @sepiropht, can you create a test case and steps to reproduce the bug? That would help diagnose the problem and come up with what the correct fix might be. Thanks! |
|
To reproduce the bug i just used the file that was referenced in the issue raytrace_parallel_bg.wasm.gz |
|
Hey @sepiropht! @fitzgen added a small test case you can use, over in #326. You should be able to use that to help finish this up. Thanks so much for opening a PR, and sorry about the slow reply! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#326
The
add_itemfunction is called two times with the same id.In one iteration we call successively
DataCountSection(section).parse_items(items, idx)?;anditems.add_root(ir::Item::new(id, name, size - added, ir::Misc::new()));with the same idx value.That why we have a panic in the
add_itemfunction.I'm suppose that id is the same because section's code is also the same ? I didn't understand further