Fix MSRV and check it in CI #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
approved these changes
Nov 5, 2024
|
I'd like to land #205 before the version bump, but this looks good, thanks! |
fitzgen
reviewed
Nov 6, 2024
| @@ -49,7 +49,7 @@ impl core::fmt::Display for MaxRecursionReached { | |||
| } | |||
| } | |||
|
|
|||
| impl core::error::Error for MaxRecursionReached {} | |||
| impl std::error::Error for MaxRecursionReached {} | |||
There was a problem hiding this comment.
Did this not break no-std builds? Shouldn't this be cfg(feature = "std")? I guess the no-std PR didn't add CI and no one caught that in review...
There was a problem hiding this comment.
Ah nvm, the nostd PR hasn't landed yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #202.