Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Raspberry Pi example #160

Closed

Conversation

btielen
Copy link

@btielen btielen commented Nov 9, 2021

  • Check that you've added documentation to any new methods
  • Rebase from master if you're not already up to date
  • Add or modify an example if there are changes to the public API
  • Add a CHANGELOG.md entry in the Unreleased section under the appropriate heading (Added, Fixed, Changed, etc)
  • Run rustfmt on the project with cargo fmt --all - CI will not pass without this step
  • Check that your branch is up to date with master and that CI is passing once the PR is opened
    Current CI configuration is not passing, changed to configuration in the PR. That one succesful.

PR description

Added a simple example based on a existing example for the Raspberry Pi. Due to some strange dependencies problems, I had to switch to rust version 2021 (stabilized in rust 1.56) which automatically solved the problems. Reconfigured and improved CircleCI configuration to support multiple examples for different targets. See #48

Thanks to @PatrickLang for creating the first example.

@btielen
Copy link
Author

btielen commented Nov 9, 2021

@jamwaffles
Copy link
Collaborator

Thanks for the PR! I haven't had much capacity to focus on this crate recently, but this PR gave me a kick to take a look at #133 again as well. IMO, I think the approach in #133 is better as it doesn't require an MSRV bump or Cargo hacks to make work so I'd like to go in that direction if you don't mind. This crate gets quite a lot of downloads so I think it's important to remain compatible even with older Rust versions.

@btielen
Copy link
Author

btielen commented Nov 12, 2021

No worries, your considerations make sense :)

@jamwaffles
Copy link
Collaborator

Thanks :). I'll close this PR in favour of #133.

@jamwaffles jamwaffles closed this Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants