Update to embedded-hal 1, merge fast-draw-improved #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Required so we can use slice::fill
This reverts commit e640e1b.
Won't pass CI because stm32f1xx-hal doesn't have the new traits yet
Don't require bus ownership and managing the CS pin
lkirkwood
added a commit
to lkirkwood/minilogger
that referenced
this pull request
May 23, 2024
PR here: rust-embedded-community/sh1106#36 Uses embedded-hal 1.0.0 which allows for easier sharing of I2c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The branch was based off of fast-draw-improved after merging the new commits in master.
Examples will need to be updated because stm32f1xx-hal doesn't yet support embedded-hal 1 traits (because of that CI won't pass either)
Porting to display-interface would probably be better in the long run and for future async support (maybe even sharing code with ssd1306 since they're pretty similar)