Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw an error if an enum has a variant with a field #733

Merged

Conversation

emarteca
Copy link
Contributor

@emarteca emarteca commented Nov 16, 2024

Fixes #732

Instead of throwing an error in lowering, I actually throw it in the parsing -- this makes more sense, since enum variant fields aren't tracked in the ast::Enum.

@emarteca emarteca marked this pull request as ready for review November 16, 2024 00:38
@Manishearth Manishearth merged commit ecd0c61 into rust-diplomat:main Nov 17, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enums where variants have contents should throw an error during lowering
2 participants