Fix distribution filtering by category bug and refactor for performance (#4590)

[coalest]

Resolves #4590

Description

Type of change

• Bug fix (Filtering on distribution -- specifically by item category -- the totals are not filtering properly (Judi, stakeholder 20240808) #4590)
  * New feature (filtering distributions by item category/id now shows the value of those items in the distribution NOT total distribution value)
• Performance improvement (to /distributions page)

How Has This Been Tested?

Added request specs

Screenshots

Below is out of date. That behavior will be moved to a new PR if it is desired
Note changes in table header for value and value amounts are now just of those items. (Many items from seeds have no value which is why the number is either very low or blank.)

Because we are no longer loading all the line_items and items for every distribution into memory, this /distributions page is now faster. Object allocation dropped significantly and it went from ~480ms to ~170ms in my development environment (seed data + laptop). But not sure what production env/data looks like.

Before:

After:

[coalest]

@cielf This PR changes the way the values are calculated when filtering distributions by items. This change wasn't requested, but I think it makes sense given that's how the total quantities act currently. Let me know if this is unwanted, and I can take that behavior out of this PR.

[cielf]

@coalest We'd want to take that column change to the business -- we have a Stakeholder Circle next Wednesday. I can definitely see a benefit to it, but they might have reasons to want to keep the other.

If it's trivial to split that out into a different PR, please do so -- otherwise, we'll hold off on this PR until next week.

[coalest]

@cielf That makes sense. I can split it into a different PR. I will move this PR back to draft until I have removed that bit of logic.

[coalest]

I removed the change regarding the value calculations. Ready for review now

[cielf]

From light testing against prod data, this is noticeably faster (not surprised).