-
-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make purchase helper pick default storage location #4722
base: main
Are you sure you want to change the base?
Make purchase helper pick default storage location #4722
Commits on Oct 14, 2024
-
Make purchase helper pick default storage location
Changed the purchase helper to use the default storage location of the organization first, before using any other storage locations that are available. Also added a (failing) spec to check that we can see the option on the page. Should be fixed in the next commit
Configuration menu - View commit details
-
Copy full SHA for bf3a652 - Browse repository at this point
Copy the full SHA bf3a652View commit details
Commits on Oct 15, 2024
-
Fix test by using extended format and
subject
Fixed the failing test by using the extended format of the test expectation and used `subject` to make an assertion regarding the response body.
Configuration menu - View commit details
-
Copy full SHA for fbab592 - Browse repository at this point
Copy the full SHA fbab592View commit details
Commits on Oct 23, 2024
-
Add test that new donation has default storage location
Added a test that when we begin to make a new donation, we have a default storage location set.
Configuration menu - View commit details
-
Copy full SHA for 231b516 - Browse repository at this point
Copy the full SHA 231b516View commit details -
Switch to use helper to set default storage location
Switched to use the helper method from PurchasesHelper to set the default storage location for a donation
Configuration menu - View commit details
-
Copy full SHA for e048651 - Browse repository at this point
Copy the full SHA e048651View commit details
Commits on Nov 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7a0ccd4 - Browse repository at this point
Copy the full SHA 7a0ccd4View commit details
Commits on Nov 13, 2024
-
Addressed review feedback namely: * Renaming new_purchase_default_location to set_default_location and moving it to ApplicationHelper. This allows us to use across both the donation and purchase forms. * Updated the tests and forms accordingly * Added specs to ApplicationHelper to test that we are able to successfully set the default storage location for purchases and donations.
Configuration menu - View commit details
-
Copy full SHA for 884500a - Browse repository at this point
Copy the full SHA 884500aView commit details
Commits on Nov 18, 2024
-
Rename method, have only one test
Renamed the method as per review suggestion and keep only one test since we only need to test that the default storage location is successfully set
Configuration menu - View commit details
-
Copy full SHA for 2716706 - Browse repository at this point
Copy the full SHA 2716706View commit details
Commits on Nov 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for dfd41ca - Browse repository at this point
Copy the full SHA dfd41caView commit details
Commits on Nov 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b88b36c - Browse repository at this point
Copy the full SHA b88b36cView commit details
Commits on Nov 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7cf2b84 - Browse repository at this point
Copy the full SHA 7cf2b84View commit details
Commits on Dec 2, 2024
-
Update spec to match new behaviour
Updated spec to match the new behaviour of the donation form.
Configuration menu - View commit details
-
Copy full SHA for f2bd834 - Browse repository at this point
Copy the full SHA f2bd834View commit details