Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make purchase helper pick default storage location #4722

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Commits on Oct 14, 2024

  1. Make purchase helper pick default storage location

    Changed the purchase helper to use the default storage location
    of the organization first, before using any other storage locations
    that are available.
    
    Also added a (failing) spec to check that we can see the option
    on the page. Should be fixed in the next commit
    lenikadali committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    bf3a652 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. Fix test by using extended format and subject

    Fixed the failing test by using the extended format
    of the test expectation and used `subject` to make
    an assertion regarding the response body.
    lenikadali committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    fbab592 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. Add test that new donation has default storage location

    Added a test that when we begin to make a new donation,
    we have a default storage location set.
    lenikadali committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    231b516 View commit details
    Browse the repository at this point in the history
  2. Switch to use helper to set default storage location

    Switched to use the helper method from PurchasesHelper
    to set the default storage location for a donation
    lenikadali committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    e048651 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2024

  1. Configuration menu
    Copy the full SHA
    7a0ccd4 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2024

  1. Address review feedback

    Addressed review feedback namely:
    * Renaming new_purchase_default_location to set_default_location
    and moving it to ApplicationHelper. This allows us to use across
    both the donation and purchase forms.
    * Updated the tests and forms accordingly
    * Added specs to ApplicationHelper to test that we are able
    to successfully set the default storage location for purchases
    and donations.
    lenikadali committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    884500a View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2024

  1. Rename method, have only one test

    Renamed the method as per review suggestion
    and keep only one test since we only need to test
    that the default storage location is successfully set
    lenikadali committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    2716706 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2024

  1. Configuration menu
    Copy the full SHA
    dfd41ca View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2024

  1. Configuration menu
    Copy the full SHA
    b88b36c View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2024

  1. Configuration menu
    Copy the full SHA
    7cf2b84 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2024

  1. Update spec to match new behaviour

    Updated spec to match the new behaviour of
    the donation form.
    lenikadali committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    f2bd834 View commit details
    Browse the repository at this point in the history