4590 filtering on distribution #4719
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
@inane-pixel This one also has changes that are not related to it. I think you branched off after having made the header changes in your main. |
dorner
requested changes
Oct 27, 2024
| } | ||
| end | ||
|
|
||
| it "ensures the totals in 'Total in Category Diapers' match" do |
There was a problem hiding this comment.
This spec doesn't seem to test the fix. It's testing the create method, not the index method.
You should be making a request spec for this, not a controller spec.
|
Added a request - also, lint needs to be addressed. |
|
Hey @inane-pixel - Checking in because the issue has gone stale. There's still some requested changes on this. |
|
@cielf Sorry, I didn't see this until now. I fixed the lint issue, but I'm not sure when I'll have a chance to work on the test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4590
Description
Type of change
How Has This Been Tested?
Checked "Total in Category" column does matches the total of the numbers in the column
Test for "Total in Category Diaper"
Screenshots