Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4138 fix delivery address #4540

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

Fix #4138 fix delivery address #4540

wants to merge 23 commits into from

Commits on Jul 19, 2024

  1. REFACTOR group examples, remove rubocop disable lines, 

    * group examples together with variables
* rubocop -A passes on this file without needing to disable ArrayAlignment
    @jimmyli97
    jimmyli97 committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    4bb8332 View commit details
    Browse the repository at this point in the history

  2. RED add rspec to test address output in distribution PDFs 

    * Compare generated against expected PDFs
* Add helper test to regenerate expected PDFs
* Add helper module
    @jimmyli97
    jimmyli97 committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    77b2a55 View commit details
    Browse the repository at this point in the history

  3. GREEN Fix rubyforgood#4138 address output changes based on delivery m… 

    …ethod

* Address output prints delivery address if filled in, otherwise partner address
* Only does this for delivery/shipped method
    @jimmyli97
    jimmyli97 committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    dcdc0f8 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. BUGFIX pdf now writes when test fails

    @jimmyli97
    jimmyli97 committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    aa38b4b View commit details
    Browse the repository at this point in the history

  2. RED add rspec for when partner has no addresses 

    * REFACTOR out profile name and email
    @jimmyli97
    jimmyli97 committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    f1d7273 View commit details
    Browse the repository at this point in the history

  3. GREEN don't print address if no address or delivery address

    @jimmyli97
    jimmyli97 committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    d64acc4 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. Merge branch 'main' into 4138-fix-delivery-address

    @jimmyli97
    jimmyli97 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    4557128 View commit details
    Browse the repository at this point in the history

  2. Add comments clarifying gitignore and comparison pdf helper rspec

    @jimmyli97
    jimmyli97 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    0d53723 View commit details
    Browse the repository at this point in the history

  3. Update bundler version

    @jimmyli97
    jimmyli97 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    d722bca View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. REFACTOR replace helper test with environment variable 

    * Use environment variable for regenerating comparison pdfs
    @jimmyli97
    jimmyli97 committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    4516951 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into 4138-fix-delivery-address

    @jimmyli97
    jimmyli97 committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    ee159ab View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. Merge branch 'main' into 4138-fix-delivery-address

    @jimmyli97
    jimmyli97 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    cec74ce View commit details
    Browse the repository at this point in the history

  2. update schema date and bundler version

    @jimmyli97
    jimmyli97 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    c26f94b View commit details
    Browse the repository at this point in the history

  3. RED remove env variable code, stub out console helper method

    @jimmyli97
    jimmyli97 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    df4b975 View commit details
    Browse the repository at this point in the history

  4. GREEN add Rails console method for generating comparison pdfs, update… 

    … comparison PDFs
    @jimmyli97
    jimmyli97 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    26ece6e View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2024

  1. Merge branch 'main' into 4138-fix-delivery-address

    @jimmyli97
    jimmyli97 committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    a21c7f2 View commit details
    Browse the repository at this point in the history

  2. Replace instance vars with structs and let

    @jimmyli97
    jimmyli97 committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    6da7702 View commit details
    Browse the repository at this point in the history

  3. FIX destroy request so db is clean, use destroy! instead so exception… 

    …s fire
    @jimmyli97
    jimmyli97 committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    8bc117e View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2024

  1. Replace FactoryBot with calling ActiveModel.create, move methods to lib/

    @jimmyli97
    jimmyli97 committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    ea7e241 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2024

  1. Fix formatting when address is incomplete, add rspecs, create and del… 

    …ete item units correctly when generating test files
    @jimmyli97
    jimmyli97 committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    39e8cb4 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into 4138-fix-delivery-address

    @jimmyli97
    jimmyli97 committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    29e59df View commit details
    Browse the repository at this point in the history

  3. FIX replace with space if partner primary contact name/email/phone is… 

    … blank

* Add rspec
* Other comparison pdfs change because previously blank phone # skipped line,
  now blank phone # adds a blank line
* Move instance_method call inside function
    @jimmyli97
    jimmyli97 committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    4c6cd65 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2024

  1. FIX spacing between issued to and delivery address

    @jimmyli97
    jimmyli97 committed Dec 4, 2024
    Configuration menu
    Copy the full SHA
    b00d1b0 View commit details
    Browse the repository at this point in the history