Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tf2: Add tf2_geometry_msgs dependency #170

Closed
wants to merge 1 commit into from
Closed

tf2: Add tf2_geometry_msgs dependency #170

wants to merge 1 commit into from

Conversation

kartikmohta
Copy link

tf2/include/tf2/impl/utils.h includes tf2_geometry_msgs/tf2_geometry_msgs.h but the dependency is missing

tf2/include/tf2/impl/utils.h includes tf2_geometry_msgs/tf2_geometry_msgs.h but the dependency is missing
@tfoote
Copy link
Member

tfoote commented Apr 12, 2016

@ros-pull-request-builder retest this please

@tfoote
Copy link
Member

tfoote commented Apr 12, 2016

Thanks for catching that. It is a problem. However adding this dependency creates a circular dependency since tf2_geometry_msgs depends on tf2 thus we should move the implementation into tf2_geometry_msgs since it cannot be used without that package anyway.

@kartikmohta
Copy link
Author

Yeah agreed, seems like some restructuring is required so I'll let you guys do it the right way :)

Copy link
Member

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in the comment this causes an issue with circular depedencies. I'm going to mark this as changes requested for tracking purposes.

@tfoote
Copy link
Member

tfoote commented Mar 22, 2018

I'm going to close this as there's now a ticket tracking it in #275 with a discussion of a better way to resolve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants