Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for multiple outcomes for each state when using Concurrence class #65

Open
wants to merge 2 commits into
base: indigo-devel
Choose a base branch
from

Conversation

carlosmccosta
Copy link

Changed the outcome_map structure in Concurrence class from {outcome:{state1:outcome1, state2:outcome2}} to {outcome:[{state1:outcome1}, {state2:outcome2}]} for allowing the specification of several outcomes for a single state (the previous implementation would not allow state1:outcome1a and state1:outcome1b, since dictionaries do not allow repeated keys).

…{state1:outcome1, state2:outcome2}} to {outcome:[{state1:outcome1}, {state2:outcome2}]} for allowing the specification of several outcomes for a single state (the previous implementation would not allow state1:outcome1a and state1:outcome1b, since dictionaries do not allow repeated keys).
@Timple
Copy link

Timple commented Aug 10, 2020

This would be easy to make backwards compatible by checking if the input is a list. If not -> convert to list with single element.

Without this I don't see this getting merged.

@carlosmccosta
Copy link
Author

Thank you for the feedback 👍
The last commit added backwards compatibility.
As such, merging this PR should add functionality without the need to update existing code from end users.

@Timple
Copy link

Timple commented Aug 11, 2020

Great, I think this is better 🙂

But I'm going to disappoint you here, I don't have anything to say in this repository. And since only 1 PR got merged since 2018 I'm going to guess it'll take a while before this gets merged.

Don't lose hope and please keep the PR open in case someone takes maintainership of this repo.

@carlosmccosta
Copy link
Author

We internally are using the branch associated with this PR, but it would be great if this PR was merged into the official repository.

@carlosmccosta
Copy link
Author

I updated this PR for ros noetic:
https://github.com/carlosmccosta/executive_smach/commits/concurrence_with_list_of_outcomes_noetic

I can either update this PR branch or create a new PR with the noetic rebased branch.

@130s
Copy link
Member

130s commented Oct 16, 2024

@carlosmccosta Sorry for a very late response. If you could update the branch toward noetic, I'm happy to merge (same as #90 (comment)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants