Transforms to global frame before checking quaternion #1261
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows goals to be accepted if the quaternion is valid once the goal has been transformed into the
global_frame
instead of requiring the quaternion to be valid in the original frame it was sent in.For my application, I have defined the transform from
earth -> map
. My map frame is in the ENU local tangent plane. Since there is a rotation between ECEF and ENU, that rotation is expressed in my transform tree.The
global_frame
that I configure for the planner is still themap
frame, and I want to be able to send waypoints in both theearth
, andmap
frame.When I attempt to send a goal point in the
earth
frame, the quaternion is not "mostly vertical" in theearth
frame, but it is once it has been transformed to theglobal_frame
.