Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix failure-codes histogram #411

Merged
merged 3 commits into from
May 5, 2021

Conversation

hsd-dev
Copy link
Contributor

@hsd-dev hsd-dev commented May 4, 2021

The PR tries to fix issues that I came across while working on #387 for failure-codes.
As for mavros/594978d/594978d.bug, I wrongly addded SYSTEM:LOSS-OF-CONTROL.
The PR will also include (if necessary) the changes from the decision in #410

Copy link
Member

@ChrisTimperley ChrisTimperley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@hsd-dev
Copy link
Contributor Author

hsd-dev commented May 5, 2021

Based on the discussion captured in #410 (comment), it was decided to keep both MODEL-REALITY-DIVERGENCE and UNINTENDED-MOVEMENT, so no changes required to the failure labels for the bugs listed in #410

@hsd-dev hsd-dev merged commit 3587436 into robust-rosin:master May 5, 2021
@hsd-dev hsd-dev deleted the fix_failure_histogram branch May 5, 2021 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants