-
-
Notifications
You must be signed in to change notification settings - Fork 848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for offline downloading of tilesets #3633
base: main
Are you sure you want to change the base?
feat: add support for offline downloading of tilesets #3633
Conversation
@mfazekas the main blocker on this right now is getting v10 vs v11 working correctly. If you have any input on how that works or any input in general on this PR let me know |
915426e
to
ae09313
Compare
ae09313
to
e452ac2
Compare
@kevinmanncito thanks much and sorry for the late answer, do you still have issue with getting both RN11 and 10 working? On which platform? I think it's fine if this is a v11 feature only, if that makes sense. |
Yeah I figured out how to handle v10 code vs v11 code on android. The issue I ran into wrapping this up is in v11 you can't do the style download and tilesets download in the same descriptor like you can in v10. Its gonna require a bit of a refactor in how things are setup doing two separate downloads. |
Description
Added
tileset offline download
. Offline map packs can now include tilesets.Checklist
CONTRIBUTING.md
yarn generate
in the root folder/example
app./example
)Screenshot OR Video
Component to reproduce the issue you're fixing
Tilesets argument can now be passed into the offline download create pack call like this: