Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Upgrades to yarn 4 and points to latest node 18 #3608

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

FrederickEngelhardt
Copy link
Contributor

@FrederickEngelhardt FrederickEngelhardt commented Sep 2, 2024

Description

Significantly faster installation of the project. Modernized dependency tools etc leveraging [email protected]

Questions

  • Is there any known reason / risk to this [email protected] upgrade? Outside of pipeline fixes for auto builds
  • Any reason to be on node 18.18.0? Node 18.20.4 contained a few fixes to jest specifically that unblocked runtime issues with jest + latest version ships corepack, but 18.18 did not expose this.

TODOS

Checklist

  • I've read CONTRIBUTING.md
  • I updated the doc/other generated code with running yarn generate in the root folder
  • I have tested the new feature on /example app.
    • In V11 mode/ios
    • In New Architecture mode/ios
    • In V11 mode/android
    • In New Architecture mode/android
  • I added/updated a sample - if a new feature was implemented (/example)

Screenshot OR Video

Component to reproduce the issue you're fixing

@mfazekas
Copy link
Contributor

mfazekas commented Sep 3, 2024

Questions

  • Is there any known reason / risk to this [email protected] upgrade? Outside of pipeline fixes for auto builds
    It's fine to upgrade to later yarn if CI and example on local works
  • Any reason to be on node 18.18.0? Node 18.20.4 contained a few fixes to jest specifically that unblocked runtime issues with jest + latest version ships corepack, but 18.18 did not expose this.
    Node 18.18 was the latest LTS when, changed it. I think we can also upgrade to node 20

@mfazekas
Copy link
Contributor

mfazekas commented Sep 12, 2024

pr needs fixing in ci

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants