Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes
scaleBarEnabled={false}
on new arch.RNMBXConvertFollyDynamicToId
converts to NSBoolean * so when assigning to a Bool prop it is always true. To fix it I used theRNMBX_OPTIONAL_PROP_BOOL
macro which handles deferencing the pointer properly.Tested in an app using new arch, before the change the scale bar is always visible even when setting
scaleBarEnabled={false}
. After the scale bar is properly hidden.Checklist
CONTRIBUTING.md
yarn generate
in the root folder/example
app./example
)Screenshot OR Video
Component to reproduce the issue you're fixing