[fix] heading not working on CustomLocationProvider (#3171)

* [android] add heading to custom location provider

* [ios] add heading to custom location provider

* export CameraStop

android/src/main/java/com/rnmapbox/rnmbx/components/location/RNMBXCustomLocationProviderManager.kt

@@ -32,6 +32,15 @@ class RNMBXCustomLocationProviderManager : ViewGroupManager<RNMBXCustomLocationP
         }
     }
 
+    @ReactProp(name = "heading")
+    override fun setHeading(view: RNMBXCustomLocationProvider, value: Dynamic?) {
+        if (value?.type == ReadableType.Number) {
+            view.heading = value.asDouble()
+        } else {
+            Logger.e(LOG_TAG, "heading is expected to be a number")
+        }
+    }
+
     override fun onAfterUpdateTransaction(view: RNMBXCustomLocationProvider) {
         super.onAfterUpdateTransaction(view)
 

android/src/main/old-arch/com/facebook/react/viewmanagers/RNMBXCustomLocationProviderManagerDelegate.java

@@ -25,6 +25,9 @@ public void setProperty(T view, String propName, @Nullable Object value) {
       case "coordinate":
         mViewManager.setCoordinate(view, new DynamicFromObject(value));
         break;
+      case "heading":
+        mViewManager.setHeading(view, new DynamicFromObject(value));
+        break;
       default:
         super.setProperty(view, propName, value);
     }

android/src/main/old-arch/com/facebook/react/viewmanagers/RNMBXCustomLocationProviderManagerInterface.java

@@ -14,4 +14,5 @@
 
 public interface RNMBXCustomLocationProviderManagerInterface<T extends View> {
   void setCoordinate(T view, Dynamic value);
+  void setHeading(T view, Dynamic value);
 }

docs/CustomLocationProvider.md

@@ -0,0 +1,39 @@
+<!-- This file was autogenerated from CustomLocationProvider.tsx do not modify -->
+
+
+
+```tsx
+import { CustomLocationProvider } from '@rnmapbox/maps';
+
+CustomLocationProvider
+
+```
+
+
+## props
+
+
+### coordinate
+
+```tsx
+Position
+```
+longitude and latitude to use for the custom location provider that gets applied to the NativeUserLocation
+
+
+
+### heading
+
+```tsx
+number
+```
+heading/bearing to use for custom location provider that gets applied to the NativeUserLocation
+
+
+
+
+
+
+
+
+

docs/NativeUserLocation.md

@@ -85,7 +85,7 @@ The name of image to use as the middle layer for the location indicator. Images
 ```tsx
 string
 ```
-The name of image asset to use as the background0 for the location indicator. Images component should define this image.
+The name of image to use as the background for the location indicator. Images component should define this image.
 
 
 

docs/docs.json

@@ -1333,7 +1333,14 @@
         "required": false,
         "type": "Position",
         "default": "none",
-        "description": "FIX ME NO DESCRIPTION"
+        "description": "longitude and latitude to use for the custom location provider that gets applied to the NativeUserLocation"
+      },
+      {
+        "name": "heading",
+        "required": false,
+        "type": "number",
+        "default": "none",
+        "description": "heading/bearing to use for custom location provider that gets applied to the NativeUserLocation"
       }
     ],
     "fileNameWithExt": "CustomLocationProvider.tsx",
@@ -4169,7 +4176,7 @@
         "required": false,
         "type": "string",
         "default": "none",
-        "description": "The name of image asset to use as the background0 for the location indicator. Images component should define this image."
+        "description": "The name of image to use as the background for the location indicator. Images component should define this image."
       },
       {
         "name": "scale",

ios/RNMBX/RNMBXCustomLocationProvider.swift

@@ -22,6 +22,11 @@ public class RNMBXCustomLocationProvider: UIView, RNMBXMapComponent {
   public var coordinate: [Double] = [] {
     didSet { changed(.coordinate) }
   }
+
+  @objc
+  public var heading: NSNumber = 0.0 {
+    didSet { changed(.heading) }
+  }
 
   func changed(_ property: Property) {
     changes.add(name: property.rawValue, update: property.apply)
@@ -50,7 +55,7 @@ public class RNMBXCustomLocationProvider: UIView, RNMBXMapComponent {
   }
 
   private func applyHeading() {
-    // updateHeading()
+    updateHeading(heading: heading.doubleValue)
   }
 
   func removeFromMap(_ map: RNMBXMapView, reason: RemovalReason) -> Bool {

ios/RNMBX/RNMBXCustomLocationProviderViewManager.m

@@ -5,5 +5,6 @@ @interface RCT_EXTERN_REMAP_MODULE(RNMBXCustomLocationProvider, RNMBXCustomLocat
 
 // circle layer props
 RCT_EXPORT_VIEW_PROPERTY(coordinate, NSArray)
+RCT_EXPORT_VIEW_PROPERTY(heading, NSNumber)
 
 @end

src/Mapbox.ts

@@ -5,6 +5,7 @@ export {
   type CameraPadding,
   type CameraAnimationMode,
   type CameraBounds,
+  type CameraStop,
 } from './components/Camera';
 export { Atmosphere } from './components/Atmosphere';
 export { default as MapView, type MapState } from './components/MapView';

src/components/CustomLocationProvider.tsx

@@ -4,7 +4,15 @@ import RNMBXCustomLocationProvider from '../specs/RNMBXCustomLocationProviderNat
 import { Position } from '../types/Position';
 
 export type Props = {
+  /**
+   * longitude and latitude to use for the custom location provider that gets applied to the NativeUserLocation
+   */
   coordinate?: Position;
+
+  /**
+   * heading/bearing to use for custom location provider that gets applied to the NativeUserLocation
+   */
+  heading?: number;
 };
 
 const CustomLocationProvider = memo((props: Props) => {

src/components/NativeUserLocation.tsx

@@ -52,7 +52,7 @@ export type Props = {
   bearingImage?: string;
 
   /**
-   * The name of image asset to use as the background0 for the location indicator. Images component should define this image.
+   * The name of image to use as the background for the location indicator. Images component should define this image.
    */
   shadowImage?: string;
 
@@ -81,7 +81,7 @@ const NativeUserLocation = memo((props: Props) => {
   let baseProps: NativeProps = { ...defaultProps };
   if (iosShowsUserHeadingIndicator) {
     console.warn(
-      'NativeUserLocation: iosShowsUserHeadingIndicator is deprecated, use puckBearingEnabled={true} puckBrearing="heading" instead',
+      'NativeUserLocation: iosShowsUserHeadingIndicator is deprecated, use puckBearingEnabled={true} puckBearing="heading" instead',
     );
     baseProps = {
       ...baseProps,

src/specs/RNMBXCustomLocationProviderNativeComponent.ts

@@ -1,5 +1,6 @@
 import type { HostComponent, ViewProps } from 'react-native';
 import codegenNativeComponent from 'react-native/Libraries/Utilities/codegenNativeComponent';
+import { Double } from 'react-native/Libraries/Types/CodegenTypes';
 
 import type { Position } from '../types/Position';
 
@@ -10,6 +11,7 @@ type OptionalProp<T> = UnsafeMixed<T>;
 
 export interface NativeProps extends ViewProps {
   coordinate?: OptionalProp<Position>;
+  heading?: OptionalProp<Double>;
 }
 
 export default codegenNativeComponent<NativeProps>(