Replace System.Drawing Font usage with SkiaSharp SKFont #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #69
At the risk of rejecting everything, I still tried replacing the use of System.Drawing with SkiaSharp.
https://github.com/mono/SkiaSharp
For cross-platform support, the use of SkiaSharp from Microsoft is recommended.
https://docs.microsoft.com/en-us/dotnet/core/compatibility/core-libraries/6.0/system-drawing-common-windows-only
This pull request replaces the usage of System.Drawing Font with SkiaSharp SKFont.
It solves issues of loading fonts in linux.
(SkiaSharp.NativeAssets.Linux)
But I don't know all other special test cases.
Thank you for feedback.